Fix reportPrivateImportUsage errors disappearing #11237
Open
+174
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pt-anthropic
force-pushed
the
claude/fix-private-import-errors-QFgW4
branch
2 times, most recently
from
1282409 to
d904088
Compare
Author
|
@microsoft-github-policy-service agree company="Anthropic" |
Author
|
Is there anything more you need from me here? |
…is tracked When a py.typed package was added to check paths (e.g., via command line), reportPrivateImportUsage errors would incorrectly disappear. This happened because addTrackedFile() was creating source files with isInPyTypedPackage=false without detecting the actual py.typed status. The fix detects py.typed status using _getModuleImportInfoForFile() when adding tracked files, similar to how setFileOpened() already does. This ensures that files from py.typed packages are correctly marked even when added directly to check paths. Added test case that reproduces the bug scenario with three packages where pkg_b re-imports from pkg_a without re-exporting, and pkg_c imports from pkg_b.
pt-anthropic
force-pushed
the
claude/fix-private-import-errors-QFgW4
branch
from
d904088 to
eaa2bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a py.typed package was added to check paths (e.g., via command line), reportPrivateImportUsage errors would incorrectly disappear. This happened because addTrackedFile() was creating source files with isInPyTypedPackage=false without detecting the actual py.typed status.
The fix detects py.typed status using _getModuleImportInfoForFile() when adding tracked files, similar to how setFileOpened() already does. This ensures that files from py.typed packages are correctly marked even when added directly to check paths.
Added test case that reproduces the bug scenario with three packages where pkg_b re-imports from pkg_a without re-exporting, and pkg_c imports from pkg_b.