Skip to content

fix: handle null close code and reason in WebSocketRoute #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Jan 29, 2026
Merged

fix: handle null close code and reason in WebSocketRoute #1886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions playwright/src/main/java/com/microsoft/playwright/impl/WebSocketRouteImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,9 @@ protected void handleEvent(String event, JsonObject params) {
sendMessageAsync("sendToPage", messageParams);
}
} else if ("closePage".equals(event)) {
int code = params.get("code").getAsInt();
String reason = params.get("reason").getAsString();
boolean wasClean = params.get("wasClean").getAsBoolean();
Integer code = params.has("code") ? params.get("code").getAsInt() : null;
String reason = params.has("reason") ? params.get("reason").getAsString() : null;
boolean wasClean = params.has("wasClean") && params.get("wasClean").getAsBoolean();
Copy link
Member

@yury-s yury-s Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wasClean is actually always present https://github.com/microsoft/playwright/blob/750fc9406c418e7f482dcbb8ca9b2c9798d19169/packages/protocol/src/protocol.yml#L3567

Copy link
Contributor Author

@nanne-rl nanne-rl Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. It could be nice to add @Nullable to the generated Java code and to run FindBugs to ensure null checks are done.

Copy link
Member

@yury-s yury-s Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an open request for public api about this #473

if (onPageClose != null) {
onPageClose.accept(code, reason);
} else {
Expand All @@ -173,9 +173,9 @@ protected void handleEvent(String event, JsonObject params) {
sendMessageAsync("closeServer", closeParams);
}
} else if ("closeServer".equals(event)) {
int code = params.get("code").getAsInt();
String reason = params.get("reason").getAsString();
boolean wasClean = params.get("wasClean").getAsBoolean();
Integer code = params.has("code") ? params.get("code").getAsInt() : null;
String reason = params.has("reason") ? params.get("reason").getAsString() : null;
boolean wasClean = params.has("wasClean") && params.get("wasClean").getAsBoolean();
if (onServerClose != null) {
onServerClose.accept(code, reason);
} else {
Expand Down
Loading