-
Notifications
You must be signed in to change notification settings - Fork 20
Add process_monitor project to solution and fix initialize_repo.ps1 #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
|
@copilot the ci is failing |
… package version Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
Fixed in commit 931eb91. The build was failing because
These were causing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR ensures the process_monitor executable is built as part of the main solution and that repository initialization correctly restores .NET dependencies for SDK-style projects.
Changes:
- Added
tools\process_monitor\process_monitor.csprojtontosebpfext.slnunder the Tools solution folder with appropriate configuration/platform mappings. - Updated
tools/process_monitor/process_monitor.csprojto importntosebpfext.propsand explicitly pinMicrosoft.Extensions.Logging.Consoleto version9.0.0, matching related projects. - Extended
scripts/initialize_repo.ps1to rundotnet restore ntosebpfext.slnafternuget restoreto correctly restore SDK-style .NET projects.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/process_monitor/process_monitor.csproj | Aligns the executable project with shared build settings and pins logging dependency version for consistent restore/build. |
| scripts/initialize_repo.ps1 | Ensures .NET SDK-style projects in the solution are restored during repo initialization. |
| ntosebpfext.sln | Adds the process_monitor executable project under the Tools folder with consistent configuration and nesting metadata so it builds with the solution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
The
process_monitorexecutable project was missing fromntosebpfext.slnwhile its library and test projects were included, preventingprocess_monitor.exefrom being built bymsbuild ntosebpfext.sln. Additionally,initialize_repo.ps1only rannuget restore(for C++ projects) but notdotnet restore(required for .NET SDK-style projects).Changes:
tools\process_monitor\process_monitor.csprojto solution under Tools folder with proper platform configurationsdotnet restore ntosebpfext.slntoinitialize_repo.ps1after thenuget restorestepprocess_monitor.csprojto include missingImportstatement for$(SolutionDir)\ntosebpfext.propsand explicit version9.0.0forMicrosoft.Extensions.Logging.Consolepackage reference to resolve CI build errorsTesting
No new tests needed. Verified project is correctly included in solution and can be restored via
dotnet restore. CI builds now pass successfully.Documentation
No documentation changes required.
Installation
No installer impact.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.