Fix LCOW DNS search bug #2594
Open
Fix LCOW DNS search bug #2594
+37,399
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the DNS domain is used as the DNS search host name inside the LCOW uVM, and the search host names configured on an adapter by HCN are ignored. Append the DNS search field to the DNS domain name, and use the result as the final list of host names to configure the LCOW uVM's `resolv.conf` with. Replace `internal\guest\network\network.go:MergeValues` with `"github.com/samber/lo".Uniq[Map]`, which does the same thing. Replace `"internal\guest\runtime\hcsv2".(*namespace).Adapters"` with an iterator-aware version (`(*namespace).allNICs() iter.Seq2`). Add a dedicated `(*namespace).dnsConfig() ([]string, []string)` function to iterate over NICs in the namespace and return the resulting search host names and name server addresses to consolidate common logic in `"internal\guest\runtime\hcsv2".setup[Sandbox|Standalone]ContainerSpec()`. Add tests for generating DNS config from NICs in namespace. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the DNS domain is used as the DNS search host name inside the LCOW uVM instead of the HCN endpoint's configured search host names (which are ignored).
Append the DNS search field to the DNS domain name, and use the result as the list of host names to configure the LCOW uVM's
resolv.confwith.Replace
"internal\guest\network".MergeValueswith"github.com/samber/lo".Uniq[Map], which does the same thing.Replace
"internal\guest\runtime\hcsv2".(*namespace).Adapters"with an iterator-aware version ((*namespace).allNICs() iter.Seq2).Add a dedicated
(*namespace).dnsConfig() ([]string, []string)function to iterate over NICs in the namespace and return the resulting search host names and name server addresses to consolidate common logic in"internal\guest\runtime\hcsv2".setup[Sandbox|Standalone]ContainerSpec().Add tests for generating DNS config from NICs in namespace.