-
Notifications
You must be signed in to change notification settings - Fork 274
C-WCOW: Enforce hashes on already mounted CIMs #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MahatiC
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
MahatiC:enforce-hashes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+131
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micromaomao
reviewed
Nov 17, 2025
9994456 to
40ae7cb
Compare
40ae7cb to
b606172
Compare
anmaxvl
reviewed
Jan 14, 2026
3c87763 to
1758527
Compare
anmaxvl
approved these changes
Jan 26, 2026
helsaawy
reviewed
Jan 27, 2026
Contributor
helsaawy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, but LGTM
3df5e5b to
33dfbbd
Compare
helsaawy
approved these changes
Jan 29, 2026
Contributor
|
needs a rebase. |
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
33dfbbd to
2f44bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if you had two containers with the same image layers, the second container would not get captured in the SecurityPolicy metadata and hence would not enforce the policy. SecurityPolicy pkg captures container image layer hashes and associates them with the ContainerID during CIM mount operation. But because the CIMs are already mounted (for the previous container), this process would not occur for the second container with the same layers.
This change caches the image layer hashes for each container and SecurityPolicy instance will capture it in the metadata later on (during layer combining) if it wasn't already captured previously for this ContainerID and enforces policy.