Tomat7 - Dark and High contrast theme.#61
Tomat7 - Dark and High contrast theme.#61Tomat7 wants to merge 8 commits intomicrosoft:masterfrom Tomat7:master
Conversation
|
|
|
Please, review pull request. |
|
Thanks. |
|
By the way, I tested with C++ environment only. |
|
|
Newrad0603
left a comment
Newrad0603
left a comment
There was a problem hiding this comment.
Please see comments for requested changes
VSColorThemes/Themes/Tomat7.xml
Outdated
| </Category> | ||
| <Category Name="Autos" GUID="{a7ee6bee-d0aa-4b2f-ad9d-748276a725f6}"> | ||
| <Color Name="ChangedText"> | ||
| <Background Type="CT_INVALID" Source="00000000" /> |
There was a problem hiding this comment.
Please remove all instances of CT_INVALID color entries. They are non-functional, but bloat the private registry.
There was a problem hiding this comment.
@Tomat7 It appears the CT_INVALID entries were replaced with CT_RAW so now you have a bunch of black on black fg/bg combinations which will make the theme unusable in certain UIs. I recommend reverting back to the CT_INVALID state, then doing a remove rather than a replace. You'll also need to remove any empty colors/categories once the CT_INVALIDs are removed per the other comment.
| <Background Type="CT_INVALID" Source="00000000" /> | ||
| <Foreground Type="CT_RAW" Source="FFF7A1A1" /> | ||
| </Color> | ||
| <Color Name="Plain Text"> |
There was a problem hiding this comment.
Once the CT_INVALID entries are removed, you'll end up with empty colors, so make sure to remove those as well. Once the empty colors are removed, you may have empty categories which should also be removed.
|
Can you please provide an overview screenshot of the theme? |
3 participants
No description provided.