add Atom One Dark Theme#58
Open
yisen-cai wants to merge 1 commit intomicrosoft:masterfrom
yisen-cai:master
Open
add Atom One Dark Theme#58yisen-cai wants to merge 1 commit intomicrosoft:masterfrom yisen-cai:master
yisen-cai wants to merge 1 commit intomicrosoft:masterfrom
yisen-cai:master
Conversation
|
|
Newrad0603
requested changes
Apr 22, 2019
| </Color> | ||
| <Color Name="MarkerFormatDefinition/FindHighlight"> | ||
| <Background Type="CT_RAW" Source="FF773800" /> | ||
| <Foreground Type="CT_INVALID" Source="00000000" /> |
Member
There was a problem hiding this comment.
Please remove all instances of CT_INVALID color entries. They are non-functional, but bloat the private registry.
| <Background Type="CT_RAW" Source="FF454545" /> | ||
| <Foreground Type="CT_INVALID" Source="00000000" /> | ||
| </Color> | ||
| <Color Name="TextMate.Classifier"> |
Member
There was a problem hiding this comment.
Once the CT_INVALID entries are removed, you'll end up with empty colors, so make sure to remove those as well. Once the empty colors are removed, you may have empty categories which should also be removed.
Member
|
You're missing updates to the registration pkgdef, the csproj, and the vsixmanifest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is copy from the vscode Atom One Dark theme, I try my best to keep track with this one, looks not bat!