Conversation
|
|
Newrad0603
requested changes
Apr 22, 2019
Member
Newrad0603
left a comment
Newrad0603
left a comment
There was a problem hiding this comment.
Please see comments for requested changes
| </Content> | ||
| </ItemGroup> | ||
| </Target> | ||
| <?xml version="1.0" encoding="utf-8"?> |
Member
There was a problem hiding this comment.
This whole file is showing up as different. Could you correct that? I'm assuming it's newline related.
| <Compile Include="Properties\AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Content Include="BlueMoon.pkgdef"> |
Member
There was a problem hiding this comment.
Please do not add theme pkgdefs. Those are binary data and are impossible to diff easily. Please use the xml format the other themes are using.
| <IncludeInVSIX>true</IncludeInVSIX> | ||
| </Content> | ||
| <Content Include="Themes\Bigface.xml" /> | ||
| <Content Include="Themes\BlueMoon.pkgdef"> |
| <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="File" Path="Themes\SublimeMaterialDark.pkgdef" /> | ||
| <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="File" Path="Themes\Tan.pkgdef" /> | ||
| <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="File" Path="ThemeRegistration.pkgdef" /> | ||
| <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="File" Path="Themes\BlueMoon.pkgdef" d:VsixSubPath="Themes" /> |
Member
There was a problem hiding this comment.
The subpath attribute is not needed
| @="Bigface" | ||
| "Name"="Bigface" | ||
|
|
||
| [$RootKey$\Themes\{c5bcc613-2c3e-4e7b-8e9e-8659acd2e1e2}] |
Member
There was a problem hiding this comment.
I don't see your actual theme file as part of this set of changes? Did you forget to add it?
Member
|
Can you please provide an overview screenshot of the theme? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Blue Moon theme. This is the theme that I have been using and evolving for a few years now. This theme works even better when you have Resharper installed and are using resharper color highlighting.