Zane/deploy to prod helm #1602
Zane/deploy to prod helm #1602
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # ============================================================================= | ||
| - stage: Stage_3 | ||
| displayName: Deploy ama-logs to CI AKS Prod Clusters via Helm | ||
| dependsOn: [] # TODO: change to Stage_2 when ready |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| image: ci-1es-managed-ubuntu-2204 | ||
| os: linux | ||
| jobs: | ||
| # TODO: repalce with our Prod cluster 1 |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| region: 'uksouth' | ||
| subscriptionId: '9b96ebbd-c57a-42d1-bbe9-b69296e4c7fb' | ||
| workspaceId: '27c54217-b1ed-4971-a1af-d22308e36201' # "DefaultWorkspace-9b96ebbd-c57a-42d1-bbe9-b69296e4c7fb-SUK" | ||
| #imageTag: '$(AgentImageTagSuffix)' #TODO: Uncomment this line to use the current release image tag |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| #imageTag: '$(AgentImageTagSuffix)' #TODO: Uncomment this line to use the current release image tag | ||
| imageTag: 3.1.33 | ||
| environment: 'CI-Deploy-To-Prod-Cluster-1' | ||
| # TODO: repalce with our Prod cluster 2 |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| region: 'centralus' | ||
| subscriptionId: '9b96ebbd-c57a-42d1-bbe9-b69296e4c7fb' | ||
| workspaceId: '55e0eb4d-129d-43bb-9435-8c598c3f7445' # "zane-test-helm2" | ||
| #imageTag: '$(AgentImageTagSuffix)' #TODO: Uncomment this line to use the current release image tag |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| value: "{{ $.Values.OmsAgent.aksResourceID }}" | ||
| - name: AKS_NODE_RESOURCE_GROUP | ||
| value: "{{ $.Values.OmsAgent.aksNodeResourceGroup }}" | ||
| {{/* TODO This needs to be fixed post Canary validation */}} |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| value: "{{ $.Values.OmsAgent.aksResourceID }}" | ||
| - name: AKS_NODE_RESOURCE_GROUP | ||
| value: "{{ $.Values.OmsAgent.aksNodeResourceGroup }}" | ||
| {{/* TODO This needs to be fixed post Canary validation */}} |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| value: "{{ .Values.OmsAgent.aksResourceID }}" | ||
| - name: AKS_NODE_RESOURCE_GROUP | ||
| value: "{{ .Values.OmsAgent.aksNodeResourceGroup }}" | ||
| {{/* TODO This needs to be fixed post Canary validation */}} |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| value: "1" | ||
| - name: AKS_RESOURCE_ID | ||
| value: "{{ .Values.OmsAgent.aksResourceID }}" | ||
| {{/* TODO This needs to be fixed post Canary validation */}} |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| value: "{{ .Values.OmsAgent.aksResourceID }}" | ||
| - name: AKS_NODE_RESOURCE_GROUP | ||
| value: "{{ .Values.OmsAgent.aksNodeResourceGroup }}" | ||
| {{/* TODO This needs to be fixed post Canary validation */}} |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| default: 'azurepubliccloud' | ||
| - name: kubernetesVersion | ||
| type: string | ||
| default: '1.32.7' |
There was a problem hiding this comment.
why are we dfaulting it to this?
| chartType: 'FilePath' | ||
| # The following chart is copied over from feature branch https://github.com/microsoft/Docker-Provider/tree/longw/addon-to-extension-quick-Test | ||
| # TODO: When it is merged to ci_prod, the following chartPath will be updated accordingly. | ||
| chartPath: '$(Build.SourcesDirectory)/charts/azuremonitor-containerinsights-for-prod-clusters' |
There was a problem hiding this comment.
is this a statis path always or with each change will this chart be rebuilt and packaged with latest?
| PROXY: {{ .Values.OmsAgent.httpProxy | b64enc | quote }} | ||
| {{- end}} | ||
| {{- if .Values.OmsAgent.trustedCA }} | ||
| PROXYCERT.crt: {{ .Values.OmsAgent.trustedCA | quote }} |
There was a problem hiding this comment.
is this chart matching what is in aks currently?
| @@ -0,0 +1,655 @@ | |||
| {{- define "get.imagetag" -}} | |||
There was a problem hiding this comment.
why do we need this file?
| @@ -0,0 +1,303 @@ | |||
| {{/* vim: set filetype=mustache: */}} | |||
| {{/* | |||
There was a problem hiding this comment.
i see a lot of unused sections here, why do we need everything that is in this file?
| @@ -0,0 +1,153 @@ | |||
| {{/* MCR repository template for adapter charts */}} | |||
There was a problem hiding this comment.
I am not sure if we need to add all these helpers to our repo
| @@ -0,0 +1,377 @@ | |||
| {{/* Auto-generated by versioning tooling, do not edit. See /toolkit/versioning/README.md for more information. */}} | |||
There was a problem hiding this comment.
i think we need to talk about these tpl files, they might not be needed in our repo
This is related to ci prod release pipeline, and use helm chart to deploy new CI images to Prod clusters during release.