feat: implement --confDir flag and add integration tests#183
Closed
p4rthh wants to merge 8 commits intometacall:masterfrom
Closed
feat: implement --confDir flag and add integration tests#183p4rthh wants to merge 8 commits intometacall:masterfrom
p4rthh wants to merge 8 commits intometacall:masterfrom
Conversation
p4rthh
force-pushed
the
feat/enable-confdir
branch
from
a7a1181 to
876f16b
Compare
p4rthh
force-pushed
the
feat/enable-confdir
branch
from
208c881 to
67488a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --confDir flag was present in the interface but marked as (TODO) in the help menu and lacked test coverage.
This PR:
Testing
Added confDir.spec.ts which creates a temporary directory with a config.ini file and verifies startup() loads the token correctly.
Verified manually by running npm start -- deploy --confDir ./custom-folder.