fix: remove cfg(production) admin bypass + merge pass pool reserves o…#425
Open
0xksure wants to merge 2 commits intometaDAOproject:developfrom
Open
fix: remove cfg(production) admin bypass + merge pass pool reserves o…#4250xksure wants to merge 2 commits intometaDAOproject:developfrom
0xksure wants to merge 2 commits intometaDAOproject:developfrom
Conversation
added 2 commits
February 13, 2026 11:12
…n cancel Two HIGH severity security fixes: 1. Admin functions bypass in non-production mode (FT-F02) All admin functions (admin_remove_proposal, admin_cancel_proposal, admin_approve_execute_multisig_proposal, collect_fees) gate admin key verification behind #[cfg(feature = "production")]. If deployed without the production feature flag, ANY signer can execute admin operations including cancelling active proposals and collecting protocol fees. Fix: Always check admin keys at runtime. 2. admin_cancel_proposal drops pass pool reserves (FT-F09) When admin cancels a proposal, only fail pool reserves are merged back to spot. Pass pool reserves are silently dropped via Rust's '..' pattern destructure, permanently stranding tokens in the AMM vault. Fix: Also merge pass pool reserves back to spot accounting.
Full documentation of 2 HIGH severity findings: - FT-F02: Admin functions bypass in non-production mode - FT-F09: admin_cancel_proposal drops pass pool reserves Includes step-by-step reproduction instructions and Anchor test examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n cancel
Two HIGH severity security fixes:
Admin functions bypass in non-production mode (FT-F02) All admin functions (admin_remove_proposal, admin_cancel_proposal, admin_approve_execute_multisig_proposal, collect_fees) gate admin key verification behind #[cfg(feature = "production")]. If deployed without the production feature flag, ANY signer can execute admin operations including cancelling active proposals and collecting protocol fees. Fix: Always check admin keys at runtime.
admin_cancel_proposal drops pass pool reserves (FT-F09) When admin cancels a proposal, only fail pool reserves are merged back to spot. Pass pool reserves are silently dropped via Rust's '..' pattern destructure, permanently stranding tokens in the AMM vault. Fix: Also merge pass pool reserves back to spot accounting.
More information https://github.com/0xksure/solana-audit-report/blob/master/PR_BODY_FUTARCHY.md