Skip to content

fix/dg col selector accessibility #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DiljohnSingh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix/dg col selector accessibility #2024

DiljohnSingh wants to merge 3 commits into from

Conversation

@DiljohnSingh
Copy link
Contributor

@DiljohnSingh DiljohnSingh commented Jan 8, 2026 •
edited
Loading

Pull request type

Bug fix (non-breaking change which fixes an issue)

Description

  • Team discovered an accessibility issue with column selector dropdown on data grid.
  • Dropdown is missing aria-selected, so screen readers are not able to figure out if a colum is selected/deselected.
  • Even though we have checkbox, but keyboard focus only reaches menu option, so setting up aria-selected on that makes sense.
  • https://mendix.atlassian.net/browse/AT-210

What should be covered while testing?

  • You should see aria-selected boolean attribute on column selector dropdown.
  • Turn on screen reader and see selection/deselection is announced.

@DiljohnSingh DiljohnSingh requested a review from a team as a code owner January 8, 2026 13:31
@DiljohnSingh DiljohnSingh force-pushed the fix/DG-col-selector-accessibility branch from 502aa4d to ec5b0a8 Compare January 8, 2026 14:27
@DiljohnSingh DiljohnSingh changed the title Fix/dg col selector accessibility fix/dg col selector accessibility Jan 8, 2026
@DiljohnSingh DiljohnSingh force-pushed the fix/DG-col-selector-accessibility branch 3 times, most recently from 7c94482 to a7d9bd6 Compare January 16, 2026 07:32
@DiljohnSingh DiljohnSingh force-pushed the fix/DG-col-selector-accessibility branch from a7d9bd6 to b05e7b9 Compare January 19, 2026 09:58
iobuhov
iobuhov approved these changes Jan 20, 2026
View reviewed changes
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iobuhov iobuhov iobuhov approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

data-widgets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DiljohnSingh @iobuhov