Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Conversation

@mattkjames7
Copy link
Contributor

@mattkjames7 mattkjames7 commented Nov 13, 2025

Save about 3 seconds per build by using Ninja to build C++ modules!

Also fix a few deprecation warnings from Rust.

@mattkjames7 mattkjames7 self-assigned this Nov 13, 2025
@mattkjames7 mattkjames7 added infrastructure Docs unnecessary Docs unnecessary Docs needed Docs needed and removed Docs unnecessary Docs unnecessary labels Nov 13, 2025
@mattkjames7 mattkjames7 added this to the mage-v3.8.0 milestone Nov 13, 2025
@mattkjames7
Copy link
Contributor Author

mattkjames7 commented Dec 4, 2025

Description

Save about 3 seconds per build by using Ninja to build C++ modules!

Also fix a few deprecation warnings from Rust.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Build using ninja-build and tidy up some warnings #694.
  • Link the documentation PR here

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@mattkjames7 mattkjames7 marked this pull request as ready for review December 4, 2025 12:27
@mattkjames7 mattkjames7 added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit dbd2e76 Dec 4, 2025
19 checks passed
@mattkjames7 mattkjames7 deleted the build-with-ninja branch December 4, 2025 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants