Fix incorrect encoding mappings for CP932 and CP936#46
Merged
mdsteele merged 1 commit intomdsteele:masterfrom Feb 13, 2026
Merged
Fix incorrect encoding mappings for CP932 and CP936#46mdsteele merged 1 commit intomdsteele:masterfrom
mdsteele merged 1 commit intomdsteele:masterfrom
Conversation
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EUC_JPtoSHIFT_JIS- these are two distinct Japanese encodings with incompatible byte sequencesBIG5toGBK- Big5 is Traditional Chinese (CP950), while GBK is Simplified ChineseDetails
The
encoding()method incodepage.rshad two incorrect mappings that would cause data corruption when decoding/encoding strings in MSI files using these code pages:encoding_rs::EUC_JPencoding_rs::SHIFT_JISencoding_rs::BIG5encoding_rs::GBK