Refactor/use anyhow errors in core-dockpack#12
Open
TomBurdge wants to merge 11 commits intomaxwellflitton:mainfrom
Open
Refactor/use anyhow errors in core-dockpack#12TomBurdge wants to merge 11 commits intomaxwellflitton:mainfrom
TomBurdge wants to merge 11 commits intomaxwellflitton:mainfrom
Conversation
* No longer used deptecrated Struct * add clippy allow for unsafe code
Contributor
Author
|
Thanks for reviewing and merging #11. You mentioned making another release soon. Right now, it's quite easy to get panicks with dockpack (e.g. docker desktop not already running). This PR removes most of these panics. |
* Function is no longer async. * No longer has opaque C type. * Therefore, can be C FFI safe again.
Closed
…s image name for push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
core-dockpack. Error types are then box dyn error via anyhow rather than Strings.expectthat could cause panicks for regular errors indockpack_push.execute_docker_buildso thattest_execute_pushdoes not fail.CreateImageOptionsin favour ofCreateImageOptionsBuilder.Reason for Change
errors -> string. Since I want to add some features, now seemed like the right time to refactor.execute_docker_build.