Refactor Hexagon backend support checks#51
Conversation
Removed static helper functions `hex_supported_src0_type`, `hex_supported_src1_type`, etc., and inlined the type checks directly into the `ggml_hexagon_supported_*` functions. This improves clarity regarding which types are supported for each operation. Also removed the unused `hex_supported_dims` function. Co-authored-by: max-krasnyansky <1380796+max-krasnyansky@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Inlined `hex_supported_dims2` into its call sites and removed the helper function. This completes the refactoring of helper functions in `ggml/src/ggml-hexagon/ggml-hexagon.cpp` to improve code clarity. Co-authored-by: max-krasnyansky <1380796+max-krasnyansky@users.noreply.github.com>
This change refactors
ggml/src/ggml-hexagon/ggml-hexagon.cppby removing several static helper functions used for checking tensor types and dimensions. The logic from these functions (hex_supported_src0_type,hex_supported_src1_type, etc.) has been inlined directly into the functions that use them (e.g.,ggml_hexagon_supported_binary,ggml_hexagon_supported_add_id). This makes it easier to see at a glance which types are supported for a given Hexagon backend operation. Additionally, the unusedhex_supported_dimsfunction was removed. The codebase was successfully compiled to ensure no regressions.PR created automatically by Jules for task 13200797414275192595 started by @max-krasnyansky