Skip to content

Refactor Hexagon backend support checks#51

Open
max-krasnyansky wants to merge 2 commits intomasterfrom
refactor-hexagon-checks-13200797414275192595
Open

Refactor Hexagon backend support checks#51
max-krasnyansky wants to merge 2 commits intomasterfrom
refactor-hexagon-checks-13200797414275192595

Conversation

@max-krasnyansky
Copy link
Owner

This change refactors ggml/src/ggml-hexagon/ggml-hexagon.cpp by removing several static helper functions used for checking tensor types and dimensions. The logic from these functions (hex_supported_src0_type, hex_supported_src1_type, etc.) has been inlined directly into the functions that use them (e.g., ggml_hexagon_supported_binary, ggml_hexagon_supported_add_id). This makes it easier to see at a glance which types are supported for a given Hexagon backend operation. Additionally, the unused hex_supported_dims function was removed. The codebase was successfully compiled to ensure no regressions.


PR created automatically by Jules for task 13200797414275192595 started by @max-krasnyansky

Removed static helper functions `hex_supported_src0_type`, `hex_supported_src1_type`, etc., and inlined the type checks directly into the `ggml_hexagon_supported_*` functions. This improves clarity regarding which types are supported for each operation. Also removed the unused `hex_supported_dims` function.

Co-authored-by: max-krasnyansky <1380796+max-krasnyansky@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions bot added the ggml label Feb 20, 2026
Inlined `hex_supported_dims2` into its call sites and removed the helper function. This completes the refactoring of helper functions in `ggml/src/ggml-hexagon/ggml-hexagon.cpp` to improve code clarity.

Co-authored-by: max-krasnyansky <1380796+max-krasnyansky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant