Add plural to Brainstem::DSL::Association#99
Open
naomiajacobs wants to merge 2 commits intomasterfrom
Open
Conversation
naomiajacobs
changed the title
plural to Brainstem::DSL::Association
Author
|
@bennapp can you review please? |
bennapp
reviewed
Nov 9, 2017
|
|
||
| context 'when `plural` is not specified in the options' do | ||
| it 'delegates to ruby singularize and pluralize to guess if the association is plural or singular' do | ||
| class Dress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the effort in: https://github.com/mavenlink/mavenlink/pull/10271
This PR adds a key to the association object called
pluralthat is set on initialization. If apluraloption is passed in, it defaults to that, otherwise it tries to figure out whether the association is plural or not by seeing if it can be singularized. This option can be used to find out whether an association is plural, and allows for an override in case it's not easily guessable from the name of the association.