Written numbers parsing integration#31
Conversation
|
Sweet. there seems to be some extra stuff in this PR. "midnight", some other changes. It'd be better if the written numbers PR was isolated. |
|
That's not from me, I don't know why it's showing up in the diffs, maybe I made a bad branching: e3ec84df90bcc2d18776102f089542a3681ee1d5 |
|
No, it's actually worse than that. The midnight diff is only showing up on dist/date.js, because I just built it again. It hasn't been |
|
ahh okay, that's the probably with distributions is that they always get out of date. |
|
It's working now, I wasn't consuming the space in the process before. All tests are working, except those containing two written numbers, like |
|
Okay, horrible idea, I don't know why it was working, but it's not clean at all. |
|
Here is what is working and not working so far: |
It's not really working yet, tests
in two daysandtwo years from yesterday at five pmare failing.I'm not really satisfied with the replacement I've found for the
.skip(), this may be the cause of the mentioned failures.