Update common files from starter template and fix linter issues#958
Open
Update common files from starter template and fix linter issues#958
Conversation
- Update Makefile with manifest-check target and newer tool versions
(golangci-lint v2.8.0, gotestsum v1.13.0)
- Update build/manifest/main.go with check command and modern Go APIs
- Update .golangci.yml to v2 format with new linters
- Update .nvmrc from 16.13.1 to 20.11
- Update .editorconfig and .github/workflows/ci.yml
- Fix all linter issues:
- Replace interface{} with any (Go 1.18+)
- Replace manual loops with slices.Contains
- Replace string concatenation in loops with strings.Builder
- Fix gofumpt formatting issues
- Add nolint directives for intentionally ignored errors
- Fix directory permissions (0755 -> 0750)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hanzei
commented
Jan 20, 2026
Contributor
Author
hanzei
left a comment
hanzei
left a comment
There was a problem hiding this comment.
Some changes in the starter template are needed first
Comment on lines
-142
to
+145
| manifest.ReleaseNotesURL, err = url.JoinPath(manifest.HomepageURL, "releases", "tag", BuildTagLatest) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to generate release notes URL") | ||
| } | ||
| manifest.ReleaseNotesURL = manifest.HomepageURL + "releases/tag/" + BuildTagLatest |
Contributor
Author
There was a problem hiding this comment.
That's a bug in the starter template. Submitted mattermost/mattermost-plugin-starter-template#236
Comment on lines
-14
to
+21
| [*.{js,jsx,ts,tsx,json,html}] | ||
| [*.{js, jsx, ts, tsx, json, html}] | ||
| indent_style = space | ||
| indent_size = 4 | ||
|
|
||
| [webapp/package.json] | ||
| indent_size = 2 | ||
|
|
||
| [Makefile,*.mk] | ||
| [{Makefile, *.mk}] |
Contributor
Author
There was a problem hiding this comment.
We should not be doing these changes. The starter template is wrong. See mattermost/mattermost-plugin-starter-template#236
There was a problem hiding this comment.
@hanzei feel free to merge the other PR and we can review these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Build tooling updates
manifest-checktarget, updated tool versionscheckcommand, modernized Go APIsLinter fixes
interface{}withany(Go 1.18+)slices.Containsstrings.BuilderTest plan
make check-stylepasses with 0 issues🤖 Generated with Claude Code