Add missing headers reported by gcc-13, fix adapter_detect() prototype consistency#705
Add missing headers reported by gcc-13, fix adapter_detect() prototype consistency#705trofi wants to merge 2 commits intomatlo:masterfrom
gcc-13, fix adapter_detect() prototype consistency#705Conversation
Without the change the build fails against `gcc-13` as:
gimx.c:587:3: error: incompatible implicit declaration
of built-in function 'free' [-Werror=builtin-declaration-mismatch]
587 | free(gimx_params.homedir);
| ^~~~
WIthout the change the build of `gcc-13` fails as:
controller.c:922:15: error: conflicting types for 'adapter_detect'
due to enum/integer mismatch; have 'e_gimx_status()' [-Werror=enum-int-mismatch]
922 | e_gimx_status adapter_detect()
| ^~~~~~~~~~~~~~
|
@trofi Hey man, are you able to compile on Win? the Inno is not creating the setup for me make[2]: Entering directory '/d/GIMX test/GIMX-build/windows/GIMX/shared/gimxcontroller' |
|
I did not try It is caused by use of blanket In |
|
Any chance you can send me the updated one? I want to compile the win version. Linux worked just fine. Eclipes IDE Any guidance really would be appreciated. |
|
@trofi I also have countless missing headers. I added them to the Path, and got a lot of them resolved. Did you had to point to the include folders and such? Thanks |
|
No, this PR (and disabled warnings) is all I needed to get it to build. |
|
To build on windows, I followed the build guide to a tee, and removed all -Werror flags. After that, it built just fine. using GCC 12 here. I have not used the code modifications listed here, either. After the build, some might have issues with Inno. You will have to fix the build script to target Inno 6 as Inno 5 is retired and hard-coded into the path. |
Two simple changes for
gcc-13compatibility:Add missing headers reported by
gcc-13controller.c: fix
adapter_detect()prototype consistency