Updates allowing to improve building on linux.#13
Open
t-w wants to merge 21 commits intomarkusC64:markusC64-v637-branchfrom
Open
Updates allowing to improve building on linux.#13t-w wants to merge 21 commits intomarkusC64:markusC64-v637-branchfrom
t-w wants to merge 21 commits intomarkusC64:markusC64-v637-branchfrom
Conversation
Otherwise, if opencbm is not available - it is not possible to build the program that do not need openpbm. Note that this modification is a quick shortcut, not resolving the problem fully (ie. install rules will not work with not all programs built...). In general, improving configuration options and build dependencies should allow to build things depending what is needed. In particular, the tools that do not require the openpbm driver, should not require it for building.
The RELATIVEPATH suggests that the build was supposed to be executed in LINUX/ directory (maybe producing binaries there), but this is inconsistent with GNU/Makefile (it, basically, does not work that way). Removing it and building things in the main project directory.
…and nibwrite). opencbm is used only by the utilities for data transfer using serial cable. Other utilities do not need it.
This reverts commit 5e83f3a. fileio needs prototype of usage (an external defined in the main module of each utility).
Make extern things already defined in read.c
usleep() is a POSIX function, not provided by c99. Proper source type must be set to build.
To update/set by user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
opencbm(nibconv,nibrepair,nibscan)opencbmis not required (where not needed/used)opencbmcan be set inLINUX/Makefilemakefilewhere the build env. can be selected (then justmake/make cleanetc.)Other notes:
I am not sure where to open a PR, if this is not the right branch let me know where (if you want to merge it).
Note that these changes are tested (briefly) only on Debian Linux. The changes are not big so should not make much trouble, but I cannot guarantee that eg. on DJGPP something unexpected won't happen, so...