Skip to content

Revert "Configures Azure Blob Storage for vcpkg cache"#658

Open
magnesj wants to merge 3 commits intodevfrom
use-gha-caching-vcpkg
Open

Revert "Configures Azure Blob Storage for vcpkg cache"#658
magnesj wants to merge 3 commits intodevfrom
use-gha-caching-vcpkg

Conversation

@magnesj
Copy link
Owner

@magnesj magnesj commented Feb 6, 2026

User description

This reverts commit 006a316.


PR Type

Enhancement


Description

  • Replace Azure Blob Storage with GitHub Actions native caching

  • Add vcpkg-cache action for binary caching support

  • Configure VCPKG_BINARY_SOURCES to use GHA cache

  • Simplify caching by removing Azure secrets dependency


Diagram Walkthrough

flowchart LR
  A["Azure Blob Storage<br/>with SAS Token"] -->|Replace| B["GitHub Actions<br/>Native Cache"]
  B --> C["vcpkg-cache Action"]
  C --> D["Local Cache Files"]
  E["VCPKG_BINARY_SOURCES<br/>Environment Variable"] -->|Updated| D
Loading

File Walkthrough

Relevant files
Enhancement
ResInsightWithCache.yml
Migrate vcpkg caching to GitHub Actions native                     

.github/workflows/ResInsightWithCache.yml

  • Added VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite" to workflow env
    for GHA caching
  • Integrated TAServers/vcpkg-cache action to restore vcpkg cache with
    GitHub token
  • Updated Configure step to use local cache files instead of Azure Blob
    Storage
  • Replaced Azure SAS token logic with simpler GHA cache path reference
  • Added clarifying comment on VCPKG_FEATURE_FLAGS setting
+10/-2   

@qodo-code-review
Copy link

qodo-code-review bot commented Feb 6, 2026

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Third-party token exposure

Description: A third-party GitHub Action (TAServers/vcpkg-cache@e5c219f...) is executed with a provided
secrets.GITHUB_TOKEN, which could enable token misuse/exfiltration if the action is
compromised or if the workflow/job permissions are overly broad; ensure the workflow sets
minimal permissions: (e.g., only what cache access requires) before passing the token to
external actions.
ResInsightWithCache.yml [198-204]

Referred Code
- name: Restore vcpkg cache
  id: vcpkg-cache
  uses: TAServers/vcpkg-cache@e5c219f91ccf7908fc284fb64f4d928715f4a154
  with:
    token: ${{ secrets.GITHUB_TOKEN }}
    prefix: vcpkg-${{ matrix.config.cxx}}/
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

qodo-code-review bot commented Feb 6, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant