Use cmake static

[magnesj]

PR Type

Enhancement

---

Description

• Convert OBJECT libraries to STATIC libraries across multiple CMake files

• Add WHOLE_ARCHIVE linker flags to preserve static initialization

• Improve debug information in Visual Studio builds

• Update documentation comments to reflect new linking strategy

---

Diagram Walkthrough

flowchart LR
  OBJ["OBJECT Libraries"] -->|Convert to| STATIC["STATIC Libraries"]
  STATIC -->|Link with| WHOLE["WHOLE_ARCHIVE Flags"]
  WHOLE -->|Preserve| INIT["Static Initialization"]
  WHOLE -->|Improve| DEBUG["Debug Information"]

Loading

File Walkthrough

	Relevant files
Enhancement	CMakeLists.txt Convert ApplicationLibCode to STATIC with WHOLE_ARCHIVE    ApplicationLibCode/CMakeLists.txt Changed ApplicationLibCode library from OBJECT to STATIC Added WHOLE_ARCHIVE linker flags for ApplicationLibCode, cafCommandFeatures, Commands, and GrpcInterface Ensures static initialization is preserved during linking +1/-1      CMakeLists.txt Convert Commands library to STATIC                                              ApplicationLibCode/Commands/CMakeLists.txt Changed Commands library from OBJECT to STATIC Aligns with overall migration to STATIC libraries +1/-1      CMakeLists.txt Convert cafCommandFeatures to STATIC library                          Fwk/AppFwk/cafCommandFeatures/CMakeLists.txt Changed cafCommandFeatures library from OBJECT to STATIC Updated documentation to explain WHOLE_ARCHIVE linker flags usage References MSVC /WHOLEARCHIVE and GCC/Clang --whole-archive flags +6/-8      CMakeLists.txt Replace TARGET_OBJECTS with WHOLE_ARCHIVE linking                Fwk/AppFwk/cafTests/cafTestApplication/CMakeLists.txt Removed TARGET_OBJECTS workaround for old CMake versions Added WHOLE_ARCHIVE linker flag for cafCommandFeatures Simplifies linking with modern CMake approach +1/-4      CMakeLists.txt Convert GrpcInterface to STATIC library                                    GrpcInterface/CMakeLists.txt Changed GrpcInterface library from OBJECT to STATIC Aligns with overall migration strategy +1/-1
Tests	CMakeLists.txt Add WHOLE_ARCHIVE flags to unit tests                                        ApplicationLibCode/UnitTests/CMakeLists.txt Added WHOLE_ARCHIVE linker flags for test executable Links ApplicationLibCode, cafCommandFeatures, Commands, and GrpcInterface with WHOLE_ARCHIVE Ensures static initialization in unit tests +9/-0

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No audit impact: The changes are limited to CMake linking and library types with no application runtime logic added, so audit trail compliance cannot be assessed from this diff. Referred Code # Link ApplicationLibCode, cafCommandFeatures, Commands, and GrpcInterface with WHOLE_ARCHIVE # to ensure static initialization is not optimized away by the linker target_link_libraries(ResInsight PRIVATE $<LINK_LIBRARY:WHOLE_ARCHIVE,ApplicationLibCode> $<LINK_LIBRARY:WHOLE_ARCHIVE,cafCommandFeatures> $<LINK_LIBRARY:WHOLE_ARCHIVE,Commands> $<$<BOOL:${RESINSIGHT_ENABLE_GRPC}>:$<LINK_LIBRARY:WHOLE_ARCHIVE,GrpcInterface>> ) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No error paths: Only build system changes are introduced (STATIC libraries and WHOLE_ARCHIVE); no runtime error handling or edge-case logic is present to validate this criterion. Referred Code # Link ApplicationLibCode, cafCommandFeatures, Commands, and GrpcInterface with WHOLE_ARCHIVE # to ensure static initialization is not optimized away by the linker target_link_libraries(ResInsight-tests PUBLIC $<LINK_LIBRARY:WHOLE_ARCHIVE,ApplicationLibCode> $<LINK_LIBRARY:WHOLE_ARCHIVE,cafCommandFeatures> $<LINK_LIBRARY:WHOLE_ARCHIVE,Commands> $<$<BOOL:${RESINSIGHT_ENABLE_GRPC}>:$<LINK_LIBRARY:WHOLE_ARCHIVE,GrpcInterface>> ) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Not applicable here: The diff only modifies CMake linking flags and targets, so no user-facing error messaging is introduced to verify secure handling. Referred Code if(USE_COMMAND_FRAMEWORK) set(TAP_LINK_LIBRARIES ${TAP_LINK_LIBRARIES} cafCommand $<LINK_LIBRARY:WHOLE_ARCHIVE,cafCommandFeatures> ) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: No logging changes: There are no additions to application logging in this PR diff; secure logging practices cannot be evaluated based on these build changes. Referred Code # Link ApplicationLibCode, cafCommandFeatures, Commands, and GrpcInterface with WHOLE_ARCHIVE # to ensure static initialization is not optimized away by the linker target_link_libraries(ResInsight PRIVATE $<LINK_LIBRARY:WHOLE_ARCHIVE,ApplicationLibCode> $<LINK_LIBRARY:WHOLE_ARCHIVE,cafCommandFeatures> $<LINK_LIBRARY:WHOLE_ARCHIVE,Commands> $<$<BOOL:${RESINSIGHT_ENABLE_GRPC}>:$<LINK_LIBRARY:WHOLE_ARCHIVE,GrpcInterface>> ) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Build-only changes: Switching to STATIC libraries and WHOLE_ARCHIVE affects linking but does not expose input validation or data handling logic to assess security posture. Referred Code add_library( ${PROJECT_NAME} STATIC ${SOURCE_GROUP_HEADER_FILES} ${SOURCE_GROUP_SOURCE_FILES} Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.