This repository was archived by the owner on Dec 21, 2024. It is now read-only.
Open
Conversation
This is needed accordign to [PEP 484](https://peps.python.org/pep-0484/)
|
thanks so much for the fix here @SpyrosRoum! @madzak anything i can do to help get this merged and released? |
Dimitrioglo
approved these changes
May 29, 2023
louis-jaris
approved these changes
Jul 3, 2023
Contributor
louis-jaris
left a comment
louis-jaris
left a comment
There was a problem hiding this comment.
Always good to follow PEP standards/best practices.
|
I see 2 approvals here, does anything stop this PR from being merged? |
Author
@madzak Needs to approve and merge it since they have write access to the repo. Considering the last commit was 10 months ago, it's probably safe to say they don't spend much time on this project anymore.. |
tdg5
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173