This repository was archived by the owner on Jan 16, 2018. It is now read-only.
Update exists? to return true if group exists#21
Closed
zachhale wants to merge 1 commit intolukeredpath:masterfrom
Closed
Update exists? to return true if group exists#21zachhale wants to merge 1 commit intolukeredpath:masterfrom
zachhale wants to merge 1 commit intolukeredpath:masterfrom
Conversation
Collaborator
|
Hi @zachhale, thanks for the patch. Unfortunately, the patch causes a failure in the build and it's missing a spec associated with the changeset. Moreover, I would kindly ask you to not commit changes to the As it is, I cannot merge this patch. Would you mind to update is according to the comments above? Can I also ask you to provide a practical example that would demonstrate what you are trying to accomplish? |
Owner
|
Closing in favour of #24 when I can get the build working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like the best place to put this. There are many times when I want to check if a group exists and
respond_to? :groupnamedoesn't work with simple config. Thoughts?