Remove set() API in favor of next(err, value) pattern #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document build commands, test commands, and high-level architecture including the continuation-passing execution flow, dependency injection system, and auto-next behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This simplifies the pipeline API by removing the incremental `set()` function and consolidating value passing through `next(err, value)`. Changes: - Delete src/set.js entirely - Simplify next() signature from (err, key, value) to (err, value) - Add setValueToStore() in pipeline.js for value-to-store mapping - Update tests to use next(null, value) pattern - Remove set-related tests and exceptions - Maintain 100% test coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Resolves conflicts between: - TypeScript conversion from master - set() API removal from this branch Changes: - Remove set() function and related types - Use next(err, value) pattern instead - Update Store.next signature from (err, key, value) to (err, value) - Remove outputMap from Pipe and PipeState types - All 35 tests passing with 100% coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set()function for incremental output setting in favor of the simplernext(err, value)patternsrc/set.jsentirely and consolidate value-to-store mapping inpipeline.jsnext()signature from(err, key, value)to(err, value)Test plan
next(null, value)patternnpm testpasses with 35 tests🤖 Generated with Claude Code