fix: update legacy Twitter and Slack logo in header#1989
Merged
dhmlau merged 1 commit intoloopbackio:gh-pagesfrom Feb 27, 2026
Merged
fix: update legacy Twitter and Slack logo in header#1989dhmlau merged 1 commit intoloopbackio:gh-pagesfrom
dhmlau merged 1 commit intoloopbackio:gh-pagesfrom
Conversation
Signed-off-by: Neeraj Deshmukh <neerajd002@gmail.com>
dhmlau
approved these changes
Feb 27, 2026
Member
|
@neerajd002, thanks for the PR. The change LGTM. Will wait for the build to complete before merging. |
Member
|
@neerajd002, thanks again for your contribution. Your PR has been merged! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1569 by updating the legacy Twitter branding to X and slack logo in the site header.
Technical Approach:
Since the site relies on Font Awesome 4.1.0 (which predates the X rebrand), upgrading the entire font library to v6 introduces a high risk of breaking existing icons due to CSS namespace changes (e.g.,
favsfa-brands).To keep the scope isolated and safe, I replaced the
<i class="fa fa-twitter"></i>tags with a clean, inline SVG of the official X logo.Changes included:
width="1em",height="1em", andfill="currentColor"to perfectly inherit the existing layout dimensions, colors, and hover states of the adjacent social icons.hrefURLs fromtwitter.comtox.com.Related Issue
Fixes #1569
Legacy Logo Screenshot
Updated Logo Screenshot
Checklist
CONTRIBUTING.mddocument.