Add failing tests for timestamps with headlines#138
Open
gagbo wants to merge 1 commit intologseq:masterfrom
Open
Add failing tests for timestamps with headlines#138gagbo wants to merge 1 commit intologseq:masterfrom
gagbo wants to merge 1 commit intologseq:masterfrom
Conversation
|
|
gagbo
force-pushed
the
headlines_timestamps
branch
from
85c2d00 to
3b29ad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only reason it is a draft is that I didn’t bring a fix, only expose a shortcoming.
It seems that mldoc cannot associate a schedule or deadline timestamp to a heading, and this might be the root cause for the issue with logbooks and repeaters in Logseq
The tests only make sure that headlines with schedules and/or deadlines are parsed "correctly" (meaning that the headline object has the corresponding properties)
It also seems that it’s hard to parse ranges for timestamps, at least I wasn’t able to express the "expected" result that I wanted