Added support for including the loader binary in the .cdt file. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeg-of-lister
commented
Aug 22, 2021
Comment on lines
+147
to
+148
| data.append(0x00) # Pulse count (L) | ||
| data.append(0x04) # Pulse count (H) |
Author
There was a problem hiding this comment.
I incremented the pulse count here because the emulator I'm using (RetroVirtualMachine) doesn't seem to implement ID12 blocks with an odd number of pulses correctly for some reason (either that or it's not setting the signal level correctly somewhere). This change doesn't seem to affect loading on real hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as an optional argument.