Conversation
mjh1
approved these changes
Nov 19, 2024
Collaborator
Author
|
Updated the PR description. For more color as to "why" : I have been testing some flags to tune for latency but the gains are marginal so I am not sure we will keep them. eg, BTW tests seem to be failing so I will hold off on merging this until I have some time to make CI green. |
Collaborator
Author
|
Tests are passing locally; the CI failures are unrelated, see #421 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds demuxer options as a complement to the existing encoder/muxer options which allows us to
This has come up a few times while looking at various things so it is good to have an API that is fully configurable out of the box.
This was partially implemented in #420 but this is more complete - it actually allows for demuxer selection and adds test cases.