Closed
Conversation
|
@Roaring30s is attempting to deploy a commit to the Livepeer Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@Roaring30s thanks for your contribution. We could also handle this globally. Curious to hear your thoughts #556. |
Member
|
Closing in favour of #556. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a UI rendering issue on the Treasury Proposal page where the "Total Support" tooltip inside the Stats section were being clipped or obscured by the adjacent Tabs component (specifically the "Votes" count badge).
The collision occurred because the Tabs and Stats components shared the same stacking context level, and the tooltips inside the Stats component did not use Portals (mobile version of ExplorerTooltip component has portal), causing them to be rendered "below" the Tabs.
Type of Change
Related Issue(s)
Fixes: #544
Changes Made
Testing
How to test (optional unless test is not trivial)
Visit: https://explorer.livepeer.org/treasury/66006623481122611164055448787310685219437663991315059574912127986740690984549?view=overview
Assure there is a vote count available and hover over the Total Support tooltip.
Impact / Risk
Risk level: Low
Impacted areas: UI
User impact: Removes visual bug
Rollback plan: PR revert
Screenshots / Recordings (if applicable)
None
Additional Notes
None