Feature/suspend lock - Ensure Desktop is locked after resume #13423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager Ensures screen is locked BEFORE suspend completes, fixing a race condition where the desktop can be briefly visible after resume. - Add new suspendLock.js module - Initialize SuspendLockManager in main.js - Uses systemd inhibitor to delay suspend until lock confirmed - Listens for LockedHint=true via D-Bus PropertiesChanged signal - 5-second timeout prevents blocking suspend forever Works with any screensaver: cinnamon-screensaver, gnome-screensaver, light-locker, xscreensaver, i3lock, swaylock, etc.
…ocking - Use GetSessionByPID as fallback when XDG_SESSION_ID is unavailable (fixes 5s timeout when 'auto' session ID fails on D-Bus) - Replace synchronous lock calls with async variants (LockRemote, Gio.Subprocess.wait_async) to prevent UI freezes - Properly disconnect PrepareForSleep and settings signals in destroy() - Only hold delay inhibitor when lock-on-suspend is enabled, with dynamic settings listener for runtime changes - Fix exit code handling with GLib.spawn_check_wait_status() - Replace TextDecoder with imports.byteArray.toString() for GJS compat - Force property sync on session proxy for reliable LockedHint caching
Author
|
I found the related Bug Report #4324 i think. |
carsteneu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a problem that has been annoying me for a long time—when the load is too high when opening my laptop, you could sometimes see the content for a few seconds. The problem is apparently well known. The PR solves the problem at the JavaScript level. It works pretty well on my laptop. Details are summarized here in a more officially tone:
Add universal pre-suspend screen lock manager
Summary
This module fixes a race condition where the desktop can be briefly visible after resume when the system is under heavy CPU load. It ensures the screen is always locked before suspend completes, regardless of which screensaver is installed.
Problem
When suspending under heavy CPU load, there's a timing window where:
Solution
The SuspendLockManager uses systemd-logind's delay inhibitor mechanism:
Features
Defense in Depth
This acts as a safety net alongside cinnamon-settings-daemon's existing lock-on-suspend functionality, ensuring the lock always completes before suspend regardless of system load or timing issues.