fix: Change installation path/location for moneo tool

[ggoklani]

Enhancement:
Change installation path/location for moneo tool

The structure we want to use for static files follows this template:
{{/opt/hpc//bin/ # one-off binaries and scripts
/opt/hpc//lib/... # resources and libraries
/opt/hpc//tools/... # standalone tools
/opt/hpc//tests/ # test scripts for local/CI testing}}

For runtime files (e.g. configuration files set up by boot services), we will store them in:

/var/hpc//....

These common directories will be defined by the following set of variables:
{{_hpc_resource_dir # /opt/hpc//
_hpc_tools_dir # /opt/hpc//tools/
_hpc_tests_dir # /opt/hpc//tests/
_hpc_runtime_dir # /var/hpc//}}
Reason:
To Maintain standard for all tools and packages.
Result:
NA
Issue Tracker Tickets (Jira or BZ if any): https://issues.redhat.com/browse/RHELHPC-140

Summary by Sourcery

Enhancements:

• Align the moneo installation directory configuration with the common Azure HPC tools directory variable to support the new filesystem structure.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the moneo tool installation path to use the common Azure tools directory variable instead of a hard-coded path, aligning it with the standardized HPC directory structure.

File-Level Changes

Change	Details	Files
Moneo installation directory now references the shared Azure tools directory variable instead of a hard-coded absolute path.	Replaced the hard-coded /opt/azurehpc/tools path for __hpc_moneo_install_dir with a templated reference to __hpc_azure_tools_dir so it follows the common installation prefix and Azure HPC directory layout. Ensured moneo installs under the standardized /opt/hpc/azure/tools hierarchy by tying it to the shared Azure tools directory variable.	vars/main.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining __hpc_moneo_install_dir after __hpc_azure_tools_dir (where that variable is declared) to avoid forward references and make the variable relationships clearer for future maintainers.
• If the goal is to standardize layout across vendors, you might want to derive __hpc_moneo_install_dir from a generic tools directory variable (e.g. __hpc_tools_dir) rather than an Azure-specific one so the role is easier to reuse in other cloud contexts.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining `__hpc_moneo_install_dir` after `__hpc_azure_tools_dir` (where that variable is declared) to avoid forward references and make the variable relationships clearer for future maintainers.
- If the goal is to standardize layout across vendors, you might want to derive `__hpc_moneo_install_dir` from a generic tools directory variable (e.g. `__hpc_tools_dir`) rather than an Azure-specific one so the role is easier to reuse in other cloud contexts.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}