endpoints: Surface failed event errors in logs#1076
Open
rexagod wants to merge 1 commit intolightspeed-core:mainfrom
Open
endpoints: Surface failed event errors in logs#1076rexagod wants to merge 1 commit intolightspeed-core:mainfrom
rexagod wants to merge 1 commit intolightspeed-core:mainfrom
Conversation
Contributor
WalkthroughAdded a debug log in the Responses API v2 streaming error branch that logs the full error_message; no control flow, error handling, or exported API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tisnik
reviewed
Jan 30, 2026
Contributor
tisnik
left a comment
There was a problem hiding this comment.
Hmm actually if you add it as debug log, it will be "secret" enough + mergeable
(I guess you use debug logging locally...)
Author
|
Moved full error response to debug level, PTAL |
I wasn't able to make out what was wrong while running LCS, as the unexpected error message wasn't much to go on with. Upon surfacing the actual error, I noticed that the failed event fired since I had hit my token limit, which I believe is useful enough information to be surfaced. I understand if this wasn't done earlier to prevent sensitive data leakage, in which case, I'll close this, or add a case to surface only when token limit is hit, although that may be tricky since different LLMs report that in different ways. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wasn't able to make out what was wrong while running LCS, as the unexpected error message wasn't much to go on with. Upon surfacing the actual error, I noticed that the failed event fired since I had hit my token limit, which I believe is useful enough information to be surfaced.
I understand if this wasn't done earlier to prevent sensitive data leakage, in which case, I'll close this, or add a case to surface only when token limit is hit, although that may be tricky since different LLMs report that in different ways.
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Checklist before requesting a review
Summary by CodeRabbit