Initate spark payments from background#48
Merged
benthecarman merged 1 commit intomasterfrom Mar 3, 2026
Merged
Conversation
Previously payments could block and we would end up waiting for the payment to complete before ever returning. This could cause our payment metadata to get screwed up as we weren't able to mark it as a trusted/rebalance payment immedaitely. Now we generate the id ourselves and init the payment in the background so we do not block on this and an safely set our payment metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously payments could block and we would end up waiting for the payment to complete before ever returning. This could cause our payment metadata to get screwed up as we weren't able to mark it as a trusted/rebalance payment immedaitely. Now we generate the id ourselves and init the payment in the background so we do not block on this and an safely set our payment metadata.