BOLT 12: clarify that offer_amount must be greater than zero#1316
Open
vincenzopalazzo wants to merge 1 commit intolightning:masterfrom
Open
BOLT 12: clarify that offer_amount must be greater than zero#1316vincenzopalazzo wants to merge 1 commit intolightning:masterfrom
vincenzopalazzo wants to merge 1 commit intolightning:masterfrom
Conversation
Add explicit requirements that: - Writers MUST set offer_amount greater than zero when present - Readers MUST NOT respond to offers where offer_amount is zero This addresses ambiguity about whether offer_amount=0 is valid. Since omitting offer_amount indicates no minimum is required, a zero value when present would be semantically incorrect. Fixes lightning#1314
t-bast
approved these changes
Feb 27, 2026
Collaborator
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
ACK 8605772, this is obvious and I think it's a bit spammy to explicitly spell it out, but why not.
@rustyrussell WDYT?
22 tasks
Contributor
Author
I agree, but I think if we have this in the spec will be obvious what to do, for instance ldk was accepting it and causing some parsing crash with cln IIRC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit requirements that:
This addresses ambiguity about whether offer_amount=0 is valid. Since omitting offer_amount indicates no minimum is required, a zero value when present would be semantically incorrect.
Fixes #1314