New localization strings (WIP)#193
Conversation
|
|
chrome beta/scripts/emerald.js
Outdated
| <div id="watch4-view-count"> | ||
| <span id="js-view-count">???,???</span> | ||
| <span id="views-text"> views</span> | ||
| <span id="views-text">${emeraldLanguageModel.views}</span> |
|
If that's not a problem, I can commit over these changes to fix up some things so they remain being correct, and add some stuff that is not in the original code yet to improve localization. |
|
Okay. |
|
I'm not sure why some things are put into several Also there should be separate localization for each layout, because some stuff is inaccurate, and fixing it will make other layouts inaccurate. For fully proper localization I'd suggest the project owner to consider using placeholders. For example: instead of because the issue with the latter is that, for example, Polish version of Cosmic Panda layout had And the thing that I guess the project owner is aware of is that some text is defined in |
I added more localization strings. I need to figure out how to change the separator in the view count from "," to " " (non-breaking space) and make the sub count match the text "subskrybentów". For example, it is supposed to be "50 454", not "50,4 tys. subskrybentów". Can you help me with this?