Add option to output all residues involved in each patch#32
Merged
Conversation
--resout). To compare patches, a patch index column is added to the outputfile and residue output.
Contributor
|
Hi, that's a great idea, thanks for implementing it. A few comments from my side:
|
Collaborator
Author
|
Hey, |
Contributor
|
Couldn't we use a with-statement for res_output? Otherwise, this looks good to me. I'd vote to make a consistent output format at some point, but this doesn't need to be here. |
Add function to output as df
…analyses into Patch_Residues_Logging
…analyses into Patch_Residues_Logging
…analyses into Patch_Residues_Logging
Contributor
|
I fixed a little bug where an additional patch was created for the non-patch area, and also implemented #34. I'll merge this now, if there are any problems with it, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To compare patches, a patch index column is added to the outputfile and residue output.
write_patches is now only called once and changed to handle multiple columns at once - to simplify patch numbering.