Open
Conversation
griwes
reviewed
Oct 4, 2016
griwes
left a comment
griwes
left a comment
There was a problem hiding this comment.
Isn't explicitly saying nonius:: everywhere with those algorithms - while in namespace nonius - too verbose?
include/nonius/configuration.h++
Outdated
| namespace detail { | ||
| template <typename T> | ||
| class optional { | ||
| // Note that this doesn't handle aligned types |
bitshifter
commented
Oct 4, 2016
Author
bitshifter
left a comment
bitshifter
left a comment
There was a problem hiding this comment.
Isn't explicitly saying nonius:: everywhere with those algorithms - while in namespace nonius - too verbose?
Most of them aren't actually in nonius namespace. The code inside cpptempl.h looks like it's 3rd party. I've removed a couple of superfluous nonius:: prefixes from main.c++ though.
include/nonius/configuration.h++
Outdated
| namespace detail { | ||
| template <typename T> | ||
| class optional { | ||
| // Note that this doesn't handle aligned types |
Author
|
I've found a problem with my optional implementation under MSVC, so will close this PR until I manage to resolve it. |
Author
|
Addressed issues with optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced everything except for boost::chrono and boost::math. Will look at math next. Fixes #47.