send SAN in certifcate for validation TLS-ALPN-01 for IP address#26
Open
orangepizza wants to merge 1 commit intoletsencrypt:mainfrom
Open
send SAN in certifcate for validation TLS-ALPN-01 for IP address#26orangepizza wants to merge 1 commit intoletsencrypt:mainfrom
orangepizza wants to merge 1 commit intoletsencrypt:mainfrom
Conversation
when tls-alpn-01 challenge used to validate ip address validator send rDNS address in SNI, but client suppose to include IPaddress in SAN in certificate returned.
orangepizza
commented
May 8, 2025
Author
orangepizza
left a comment
There was a problem hiding this comment.
in this setting user supposed to add challange on rDNS domain to get a validation challenge to work: would it better if this catch ip-like add/del chall request and redirect them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when tls-alpn-01 challenge used to validate ip address validator send rDNS address in SNI, but client suppose to include IPaddress in SAN in certificate returned.
PS. go 1.13 looks really old, didn't touched though.