Skip to content

Pmd ops #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PZahnen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pmd ops #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c3b00
refactor OpsRequestDispatcherImpl method names and error handling
PZahnen Jan 6, 2026
600a86e
surpressed warnings
PZahnen Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions xtraplatform-ops/src/main/java/de/ii/xtraplatform/ops/app/OpsPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

@Singleton
@AutoBind
@SuppressWarnings("PMD.DataClass")
public class OpsPlugin implements DropwizardPlugin {

private final OpsRequestDispatcher opsRequestDispatcher;
Expand All @@ -39,6 +40,7 @@ public class OpsPlugin implements DropwizardPlugin {
}

@Override
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
public void init(AppConfiguration configuration, Environment environment) {
ServletHandler servletHandler = environment.getAdminContext().getServletHandler();
ServletHolder[] holders = servletHandler.getServlets();
Expand Down Expand Up @@ -92,6 +94,7 @@ private static class OpsResourceConfig extends ResourceConfig {
private String contextPath;

public OpsResourceConfig() {
super();
this.urlPattern = "/*";
this.contextPath = "/";

Expand Down
17 changes: 8 additions & 9 deletions xtraplatform-ops/src/main/java/de/ii/xtraplatform/ops/app/OpsRequestDispatcherImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public class OpsRequestDispatcherImpl implements OpsRequestDispatcher {
private final StaticResourceServlet staticServlet;
private final Lazy<Set<OpsEndpoint>> subEndpoints;
private Servlet tasksServlet;
private final Reader reader;
private final OpenAPI openAPI;

@Inject
Expand All @@ -95,7 +94,7 @@ public class OpsRequestDispatcherImpl implements OpsRequestDispatcher {

ModelConverters.getInstance().addConverter(new CustomModelConverter());

this.reader = new Reader(new OpenAPI());
Reader reader = new Reader(new OpenAPI());
Set<Class<?>> endpointClasses =
subEndpoints.get().stream().map(OpsEndpoint::getClass).collect(Collectors.toSet());
endpointClasses.add(this.getClass());
Expand Down Expand Up @@ -124,7 +123,7 @@ public void init(ServletConfig servletConfig, ServletHolder tasksServlet) {
tasksServlet.initialize();
this.tasksServlet = tasksServlet.getServletInstance();
} catch (Exception e) {
throw new RuntimeException(e);
throw new IllegalStateException("Failed to initialize servlets", e);
}
}

Expand Down Expand Up @@ -258,7 +257,7 @@ public static class Capability {
schema = @Schema(implementation = HealthResponse.class))),
@ApiResponse(responseCode = "500", description = "Internal server error")
})
public void getHealth(@Context HttpServletRequest request, @Context HttpServletResponse response)
public void health(@Context HttpServletRequest request, @Context HttpServletResponse response)
throws ServletException, IOException {
CorsFilter.addCorsHeaders(response);
healthCheckServlet.service(request, response);
Expand Down Expand Up @@ -316,7 +315,7 @@ public static class Timer {
@ApiResponse(responseCode = "401", description = "Unauthorized"),
@ApiResponse(responseCode = "500", description = "Internal server error")
})
public void getMetrics(@Context HttpServletRequest request, @Context HttpServletResponse response)
public void metrics(@Context HttpServletRequest request, @Context HttpServletResponse response)
throws ServletException, IOException {
CorsFilter.addCorsHeaders(response);
metricsServlet.service(request, response);
Expand All @@ -342,7 +341,7 @@ public enum PingResponse {
schema = @Schema(implementation = PingResponse.class))),
@ApiResponse(responseCode = "500", description = "Internal server error")
})
public void getPing(@Context HttpServletRequest request, @Context HttpServletResponse response)
public void ping(@Context HttpServletRequest request, @Context HttpServletResponse response)
throws ServletException, IOException {
CorsFilter.addCorsHeaders(response);
pingServlet.service(request, response);
Expand All @@ -365,7 +364,7 @@ public void getPing(@Context HttpServletRequest request, @Context HttpServletRes
"\"dw-admin-105\" id=105 state=TIMED_WAITING - waiting on <0x04941bd8> (a java.util.concurrent.SynchronousQueue$Transferer) - locked <0x04941bd8> (a java.util.concurrent.SynchronousQueue$Transferer) at java.base@21.0.5/jdk.internal.misc.Unsafe.park(Native Method) at java.base@21.0.5/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:410) at java.base@21.0.5/java.util.concurrent.LinkedTransferQueue$DualNode.await(LinkedTransferQueue.java:452) at java.base@21.0.5/java.util.concurrent.SynchronousQueue$Transferer.xferLifo(SynchronousQueue.java:194) at java.base@21.0.5/java.util.concurrent.SynchronousQueue.xfer(SynchronousQueue.java:235) at java.base@21.0.5/java.util.concurrent.SynchronousQueue.poll(SynchronousQueue.java:338) at app/de.ii.xtraplatform.runtime.tpl@6.3.0-SNAPSHOT/org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.reservedWait(ReservedThreadExecutor.java:325) at app/de.ii.xtraplatform.runtime.tpl@6.3.0-SNAPSHOT/org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:401) at app/de.ii.xtraplatform.runtime.tpl@6.3.0-SNAPSHOT/org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969) at app/de.ii.xtraplatform.runtime.tpl@6.3.0-SNAPSHOT/org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194) at app/de.ii.xtraplatform.runtime.tpl@6.3.0-SNAPSHOT/org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149) at java.base@21.0.5/java.lang.Thread.runWith(Thread.java:1596) at java.base@21.0.5/java.lang.Thread.run(Thread.java:1583)"))),
@ApiResponse(responseCode = "500", description = "Internal server error")
})
public void getThreads(@Context HttpServletRequest request, @Context HttpServletResponse response)
public void threads(@Context HttpServletRequest request, @Context HttpServletResponse response)
throws ServletException, IOException {
CorsFilter.addCorsHeaders(response);
threadDumpServlet.service(request, response);
Expand Down Expand Up @@ -422,7 +421,7 @@ public OpsEndpoint getOther(@PathParam("entrypoint") String entrypoint) {
@GET
@Path("/{path: .+\\.(?:html|js|css|json|woff2|txt)}")
@Hidden
public void getFile(
public void file(
@PathParam("path") String path,
@Context HttpServletRequest request,
@Context HttpServletResponse response)
Expand All @@ -434,7 +433,7 @@ public void getFile(
@GET
@Path("/{path: .*}")
@Hidden
public void getRoute(
public void route(
@PathParam("path") String path,
@Context HttpServletRequest request,
@Context HttpServletResponse response)
Expand Down