rely on request redraw for event processing#969
Open
jrmoulton wants to merge 1 commit intolapce:mainfrom
Open
Conversation
Collaborator
Author
|
This will be something that anyone reviewing prs should be mindful of and as we make changes to Floem, try to reduce blocking everywhere that isn't under a request redraw. |
Collaborator
Author
|
This is currently breaking timers so things like exec_after aren't running. the timers are being created but they are never being fired |
Collaborator
Author
|
I'm reworking the layout system. I'll get back to this once that is done in the next day or so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is necessary. if we try to process events right after they happen, if the processing takes a long time, there will be a long string of queued up events before the request redraw and we will miss frames.
We should as much as possible ensure that events emitted by winit other than request redraw do not block.