Add info about env vars for Geneva workers#142
Merged
Conversation
dantasse
requested review from
BubbleCal,
jmhsieh,
justinrmiller and
rpgreen
dantasse
commented
Feb 12, 2026
| .head_group( | ||
| image="myregistry.example.com/my-custom-head-image:latest", | ||
| ) | ||
| .add_worker_group(KubeRayClusterBuilder.cpu_worker() |
Contributor
Author
There was a problem hiding this comment.
Sorry, this is not the same thing, but I noticed it while I was here - want to make this tip clear that you can define images for head or workers this way.
jmhsieh
approved these changes
Feb 13, 2026
Contributor
jmhsieh
left a comment
jmhsieh
left a comment
There was a problem hiding this comment.
remove the create_external in the commend and this is good to go
|
|
||
| ```python Python icon="python" | ||
| cluster = ( | ||
| GenevaCluster.create_kuberay(cluster_name) # or create_external(cluster_name) |
Contributor
There was a problem hiding this comment.
I don't think this works with create_external as the code stands today. Just remove this comment?
Contributor
There was a problem hiding this comment.
ah, saw patches to add support with create_external clusters
Contributor
Author
There was a problem hiding this comment.
yeah, I'll merge this right after I merge that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/lancedb/issue/GEN-282/docs-show-how-to-send-env-vars-to-workers
Multiple users have had questions about how to send env vars to workers. In addition to https://github.com/lancedb/geneva/pull/552 and https://github.com/lancedb/geneva/pull/551, this will make it easier to figure out how to do so.