Conversation
This commit refactors the gallery data models and their mapping logic to better handle nullable fields and improve code clarity. Key changes: - **Contract Updates**: Changed `blurhash` and `displayBlurHash` to nullable strings in `GalleryPhoto` and the `GalleryDisplayable` interface. - **Improved Mapping**: Refactored the mapping logic in `GalleryViewModel` for photos, collections, and topics to use named arguments for better readability. - **Null Safety**: Added null-safe access and default values when mapping `GalleryTopic` from the domain model, specifically handling cases where `coverPhoto` or user information might be missing.
lackary
added
bug
3 tasks
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
lackary
deleted the
chore/35-update-omnifeed-to-support-null-safety-changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #35
Type of Change
Please check the main type of change this PR introduces. If there are multiple, please select the most significant one.
Description
[Please provide a detailed description of the changes in this PR. For example: What bug does this PR fix? What feature does it add?]
How to test it?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Tested Platforms:
Test Details:
Review Checklist
Before submitting this PR, please confirm the following: