fix: set 0 as default max_BLACS_conn_length#119
Open
YinFengQi wants to merge 2 commits intolabscript-suite:masterfrom
Open
fix: set 0 as default max_BLACS_conn_length#119YinFengQi wants to merge 2 commits intolabscript-suite:masterfrom
max_BLACS_conn_length#119YinFengQi wants to merge 2 commits intolabscript-suite:masterfrom
Conversation
- Set the default value of `max_BLACS_conn_length` to 0 so that the `np.empty` always receives a valid arguement - Fixes labscript-suite#118
Contributor
|
I've thought about this a bit more, and I now agree we should just update the base class with the correct default attribute. Could you update this PR to do that? I'd say we should go ahead and keep the -1 to 0 change as well, for extra good measure. |
- Define the attribute `BLACS_connection` in base class `Device`, to ensure that all `Device` subclasses have this attribute. Suggested-by: @dihm
Author
|
Updated just now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_BLACS_conn_lengthto 0 so that thenp.emptyalways receives a valid arguement