Draft
Conversation
# Conflicts: # Mesh/TPZCompMeshTools.cpp # Mesh/TPZCompMeshTools.h # Mesh/TPZMultiphysicsCompMesh.cpp # Mesh/pzcondensedcompel.cpp # Mesh/pzcondensedcompel.h # Mesh/pzelchdiv.cpp # Pre/TPZMHMixedMeshControl.cpp
pedrolimasi
requested review from
PabloGSCarvalho,
denisesiq,
gustavobat,
jbvilleg and
orlandini
Member
|
Dear @pedrolima92, the PR #67 is bound to happen later today. I suggest we wait a little bit longer on this one, so we could merge RefactorGeom back to MHM_Hybrid_Mixed. I am not so sure how would commits like 29373e1 and ff70801 would work out as it is. |
Member
Author
|
Sure @orlandini I was admitting the possibility that PR #67 would come first.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@philippedevloo Has made a few improvements to mixed MHM approximations. Those would best be listed and detailed by him. But I'm sure he'll happily answer any questions you have.
Please run your target tests on this branch and report back what breaks and what works, so we can merge it to development branch (RefactorGeom).
@gustavobat @PabloGSCarvalho @denisesiq @jbvilleg
@karolinneoc I remember him citing you, and you finding it strange. If you can report your results too anyway, thanks for the help.