Conversation
krishauser
requested changes
May 15, 2025
Owner
krishauser
left a comment
krishauser
left a comment
There was a problem hiding this comment.
Committing changes to way too many files.
GEMstack/knowledge/detection/Cone.pt
Outdated
Owner
There was a problem hiding this comment.
There is already a cone.pt in this folder
.catkin_workspace
Outdated
Owner
There was a problem hiding this comment.
Why would you increment the x and y?
Owner
There was a problem hiding this comment.
Whats the difference between parking space detector and space detector?
Collaborator
|
@Rohit-R-Rao it seems you’ve added your creep control file on top of a parking local test branch. That’s why there’s a lot of unclean files in this pr @krishauser these new parking test files should not be merged @Rohit-R-Rao branch off of s2025 directly and add your file there and open a new PR |
Rohit-R-Rao
force-pushed
the
creep-parking-planning
branch
from
e98b16c to
0f64693
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I addressed the duplication issues I was having with creep_planning.py with the control PR. I have fixed my code to be integrated with planning and parkings final branch. I fixed the issues with reliability as well. Please let me know if there is any issue with this now.
The code I have included is in Gemstack/onboard/planning/creep_planning.py
I utilized the parking_motion_planning to handle the longitudinal plan calls.
This code is different from the code in control PR.