Skip to content

Conversation

@aravindtga
Copy link
Contributor

Description

This PR continues the refactoring effort by moving two additional internal packages (errors and fnruntime) from internal/ to pkg/lib/ to expose them as part of the publicly accessible Library. This is the third phase of the broader refactoring effort to make key utilities available to external consumers.

Changes

Move:

  • internal/errors/pkg/lib/errors/
  • internal/fnruntime/pkg/lib/fnruntime/

Update:

  • Import statements across multiple command and internal files to reference the new public library locations
  • Error resolver components reorganized with improved package structure

This change includes updates from the following porch pull requests:

Future Work

This continues the systematic refactoring to move internal packages to the public library. Additional internal packages will be evaluated and moved in subsequent phases to create a comprehensive and accessible library interface for kpt consumers.

Signed-off-by: aravind.est <aravindhan.a@est.tech>
@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 221190f
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/696532a9d21f0c00080c436f
😎 Deploy Preview https://deploy-preview-4346--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there were quite a few improvements to port over from Porch in this one.

@liamfallon liamfallon self-requested a review January 13, 2026 07:05
@liamfallon
Copy link
Contributor

It looks like the CLI tests are failing. These tests may also be duplicated, fixed, and running in Porch, it's probably worth checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants