new feature: add remove node in EdgeWidget (Done)#29
new feature: add remove node in EdgeWidget (Done)#29Shnku wants to merge 6 commits intokoaning:mainfrom
Conversation
modified: wigglystuff/static/edgedraw.js
|
Thanks for the idea/PR. This feature could work but before diving deeper into the code I would first like to discuss the experience. 
I don't mind the feature, but as is, it looks a little bit ugly. I would like the buttons to actually look like buttons. I also think we should make this configurable. The default behavior was fine, where you only have a static set of nodes to work with. But if you want to have something interactive I'm open to it but there should be some sort of setting. Maybe I also notice that when I remove a node that it can remove all connections that have been drawn. |
generated with makefile - issue with remove node - buttons styling - lebel color to red modified: js/edgedraw.js modified: wigglystuff/static/edgedraw.css
syncing upstream changes with add-remove node
- add node by name - remove selected node or by name modified: js/edgedraw.js modified: wigglystuff/static/edgedraw.css modified: wigglystuff/static/edgedraw.js
Shnku
changed the title
|
The feature of add remove node in edge-widget is ready .. and synced with current directory structured. waiting for your review and reply @koaning |
2 participants
i modified this file tail
wigglystuff/static/edgedraw.js#27 basic things works ..