feat: replace the /hardware with new denormalized view and remove /hardware-new #1712
Conversation
There was a problem hiding this comment.
ditto reuse parts between hardware pages
There was a problem hiding this comment.
Is there really a need to do both cases for the same value? IMO you can have just one case for that value and use it in both pages
There was a problem hiding this comment.
Reuse some parts for the new hardware page, and you can target this PR to the one that replaces the treeListing so that you can use things from there too, like the banner message and status types
gustavobtflores
force-pushed
the
feat/replace-new-hardware-page
branch
from
52e5192 to
184dc25
Compare
AmadeusK525
left a comment
AmadeusK525
left a comment
There was a problem hiding this comment.
I guess if you renamed the old one to v1 you should rename the new one to v2, no?
My concern with /hardware/v2 is that it would require redirecting users from /hardware, which adds avoidable complexity. I'd prefer to keep the new one at /hardware and the old one at /hardware/v1 |
It's best if we keep the route as /hardware for backwards compatibility and also because we don't need to increase the url size for no reason. What could be done is what I did for the treeListing on #1709 which is to have three routes: /tree/v1, /tree/v2, and just /tree, meaning routes for specific version and a route for the latest/main version |
|
@gustavobtflores there seems to not have much change since the last time I reviewed the PR, you can let me resolve my comments once I see that they have been solved |
gustavobtflores
force-pushed
the
feat/replace-new-hardware-page
branch
from
184dc25 to
6e714ca
Compare
3 participants
Description
Promote the new, optimized hardware listing page to be the default view (/hardware) and move the legacy view to an archive route.